Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reduction queue lengths to Diagnostics page and move to ActiveMQ Artemis #194

Closed
wants to merge 4 commits into from

Conversation

rosswhitfield
Copy link
Member

@rosswhitfield rosswhitfield commented Nov 15, 2024

Description of the changes

7796: [WebMon] Add autoreducer queue sizes to diagnostics page

If you go to http://localhost/dasmon/common/diagnostics/ you should see the new table
2024-11-15-135832_293x121_scrot

One way to test is the stop a autoreducer container and run a system test causing runs to be added to the queue without being consumed. e.g.

docker stop data_workflow-autoreducer_himem-1
python -m pytest tests/test_autoreducer_high_memory.py

the test will fail but now you should see
2024-11-15-140115_286x118_scrot

Check all that apply:

  • updated documentation
  • Source added/refactored
  • Added unit tests
  • Added integration tests
  • (If applicable) Verified that manual tests requiring the /SNS and /HFIR filesystems pass without fail

References:

  • Links to IBM EWM items:
  • Links to related issues or pull requests:

Manual test for the reviewer

(Instructions for testing here)

Check list for the reviewer

  • best software practices
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.87%. Comparing base (6dae8e1) to head (9b0e7a2).

Files with missing lines Patch % Lines
src/dasmon_app/dasmon_listener/amq_consumer.py 0.00% 2 Missing ⚠️
src/webmon_app/reporting/dasmon/view_util.py 90.90% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next     #194      +/-   ##
==========================================
+ Coverage   77.78%   77.87%   +0.08%     
==========================================
  Files          54       54              
  Lines        4717     4745      +28     
==========================================
+ Hits         3669     3695      +26     
- Misses       1048     1050       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@rosswhitfield rosswhitfield changed the title Add reduction queue lengths to Diagnostics page Add reduction queue lengths to Diagnostics page and move to ActiveMQ Artemis Nov 19, 2024
@rosswhitfield rosswhitfield marked this pull request as ready for review November 19, 2024 04:05
@rosswhitfield rosswhitfield marked this pull request as draft November 19, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants