Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove link to webref from run page #195

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Remove link to webref from run page #195

merged 3 commits into from
Nov 19, 2024

Conversation

backmari
Copy link
Contributor

@backmari backmari commented Nov 15, 2024

Description of the changes

  • Remove link "fit data" that links to WebRef from REF_L since it WebRef been decommissioned, see e.g. https://monitor.sns.gov/report/ref_l/214747/
  • Enable testing in the test environment of the REF_L run page by advancing the webmonchow version and adding needed test data (fake /SNS file system directories for REF_L)
  • Modify WebMon certificate configuration to enable both local self-signed certificate for use with the local Live Data Server and standard certificate for use with ONCat

Check all that apply:

  • updated documentation
  • Source added/refactored
  • Added unit tests
  • Added integration tests
  • (If applicable) Verified that manual tests requiring the /SNS and /HFIR filesystems pass without fail

References:

Manual test for the reviewer

  1. Ask developer for ONCat credentials to use in local developer environment.
  2. Build the local environment according to instructions in readthedocs.
  3. Go to http://localhost/report/ref_l/214747/
  4. Verify that the link "fit data" no longer appears, but the link "Data access: download plot data points" is visible.

image

Check list for the reviewer

  • best software practices
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.79%. Comparing base (6dae8e1) to head (15107b0).

Additional details and impacted files
@@            Coverage Diff             @@
##             next     #195      +/-   ##
==========================================
+ Coverage   77.78%   77.79%   +0.01%     
==========================================
  Files          54       54              
  Lines        4717     4711       -6     
==========================================
- Hits         3669     3665       -4     
+ Misses       1048     1046       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@backmari backmari force-pushed the remove_webref_link branch 2 times, most recently from c5a0d83 to 627511d Compare November 18, 2024 14:12
@backmari backmari marked this pull request as ready for review November 18, 2024 15:35
@backmari backmari merged commit 5d250e6 into next Nov 19, 2024
4 checks passed
@backmari backmari deleted the remove_webref_link branch November 19, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants