Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch ActiveMQ from classic to artemis #196

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Conversation

rosswhitfield
Copy link
Member

@rosswhitfield rosswhitfield commented Nov 19, 2024

Description of the changes

This changes the activemq used in the test docker-compose from the classic to artemis. I copied the configuration from https://code.ornl.gov/sns-hfir-scse/deployments/amqbroker_artemis_deploy but I had to make a small change. I added connectionTtl=300000 to the STOMP Acceptor, so 5 minutes, it could probably be shorter. The default was 1 minute which was causing dasmon to timeout because it was only sending a heartbeat every 2 minutes as set here. Alternatively we can increase the frequency of heartbeats sent from dasmon.

I also needed to change the dasmon amq_consumer.py to subscribe to queues using an unique ID per connection because artemis was rejecting the subscriptions if the ID was the same.

Check all that apply:

  • updated documentation
  • Source added/refactored
  • Added unit tests
  • Added integration tests
  • (If applicable) Verified that manual tests requiring the /SNS and /HFIR filesystems pass without fail

References:

  • Links to IBM EWM items:
  • Links to related issues or pull requests:

Manual test for the reviewer

(Instructions for testing here)

Check list for the reviewer

  • best software practices
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.78%. Comparing base (6dae8e1) to head (6bcd9d6).

Files with missing lines Patch % Lines
src/dasmon_app/dasmon_listener/amq_consumer.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             next     #196   +/-   ##
=======================================
  Coverage   77.78%   77.78%           
=======================================
  Files          54       54           
  Lines        4717     4717           
=======================================
  Hits         3669     3669           
  Misses       1048     1048           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@rosswhitfield rosswhitfield marked this pull request as ready for review November 19, 2024 04:59
Copy link
Contributor

@backmari backmari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally that communication between services behaves as before after the change of message broker. Looks good!

@rosswhitfield rosswhitfield merged commit de13b21 into next Nov 20, 2024
4 checks passed
@rosswhitfield rosswhitfield deleted the activemq-artemis branch November 20, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants