Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing build dependency #205

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Add missing build dependency #205

merged 1 commit into from
Dec 17, 2024

Conversation

backmari
Copy link
Contributor

@backmari backmari commented Dec 17, 2024

Description of the changes

The post-merge publish step failed to build wheels with the error:

ERROR Missing dependencies:
	wheel

The failing job: https://github.com/neutrons/data_workflow/actions/runs/12376853545/job/34544952851

It is not clear why this started failing now, but adding wheel explicitly in the conda environment file fixes the problem.

Check all that apply:

  • updated documentation
  • Source added/refactored
  • Added unit tests
  • Added integration tests
  • (If applicable) Verified that manual tests requiring the /SNS and /HFIR filesystems pass without fail

References:

  • Links to IBM EWM items:
  • Links to related issues or pull requests:

Manual test for the reviewer

(Instructions for testing here)

Check list for the reviewer

  • best software practices
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.86%. Comparing base (cd46764) to head (fd32e78).

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #205   +/-   ##
=======================================
  Coverage   77.86%   77.86%           
=======================================
  Files          54       54           
  Lines        4730     4730           
=======================================
  Hits         3683     3683           
  Misses       1047     1047           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rosswhitfield rosswhitfield merged commit 340030e into next Dec 17, 2024
4 checks passed
@rosswhitfield rosswhitfield deleted the wheel_dependency branch December 17, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants