Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #169 from neutrons/live_plot_Authorization" #206

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

backmari
Copy link
Contributor

@backmari backmari commented Dec 20, 2024

This reverts commit 157d1ba, reversing changes made to 636c61e.

Description of the changes

This draft PR is a contingency plan to be able to upgrade the WebMon version without upgrading Live Data Server. It rolls back the change to pass the Live Data Server API key in the authorization header rather than the URL.

Check all that apply:

  • updated documentation
  • Source added/refactored
  • Added unit tests
  • Added integration tests
  • (If applicable) Verified that manual tests requiring the /SNS and /HFIR filesystems pass without fail

References:

  • Links to IBM EWM items:
  • Links to related issues or pull requests:

Manual test for the reviewer

(Instructions for testing here)

Check list for the reviewer

  • best software practices
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

@backmari backmari marked this pull request as draft December 20, 2024 16:13
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.88%. Comparing base (340030e) to head (d43057e).

Files with missing lines Patch % Lines
src/webmon_app/reporting/report/view_util.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next     #206      +/-   ##
==========================================
+ Coverage   77.86%   77.88%   +0.02%     
==========================================
  Files          54       54              
  Lines        4730     4735       +5     
==========================================
+ Hits         3683     3688       +5     
  Misses       1047     1047              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@backmari backmari force-pushed the revert_live_plot_Authorization branch from 5477dd5 to 8f04f50 Compare January 6, 2025 16:09
@backmari backmari force-pushed the revert_live_plot_Authorization branch from fbac362 to d43057e Compare January 7, 2025 20:29
@backmari backmari marked this pull request as ready for review January 8, 2025 16:59
Copy link
Member

@peterfpeterson peterfpeterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks like the opposite of the two referenced PRs

@backmari backmari merged commit 800033b into next Jan 8, 2025
4 checks passed
@backmari backmari deleted the revert_live_plot_Authorization branch January 8, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants