Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update codecov #19

Merged
merged 2 commits into from
Mar 28, 2024
Merged

update codecov #19

merged 2 commits into from
Mar 28, 2024

Conversation

searscr
Copy link
Contributor

@searscr searscr commented Mar 27, 2024

Description of Changes:

  • Update codecov target and threshold.
  • Ensure that codecov runs for every PR

Related Items

Relates to EWM #4422

To Test:

cd /path/to/my/local/garnet/repo/
git fetch origin pull/<PULL_REQUEST_NUMBER>/head:pr<PULL_REQUEST_NUMBER>
git switch pr<PULL_REQUEST_NUMBER>
conda activate <garnet_environment>
python -m pytest <item_to_test>

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5251181) to head (212049a).

Additional details and impacted files
@@            Coverage Diff            @@
##              next       #19   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          236       236           
=========================================
  Hits           236       236           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

target: 90%
threshold: 2%
target: 90.0
threshold: 2.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we also update the documentation with information about the required test coverage threshold/target for PRs in the related section, please?

Copy link
Collaborator

@mpatrou mpatrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!!

@searscr searscr merged commit 4a59b24 into next Mar 28, 2024
6 checks passed
@searscr searscr deleted the ewm4422 branch March 28, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants