NR-346357: Sync up nr-ebpf-agent charts in helm-charts from newrelic-… #1537
+546
−117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nravada
requested review from
kpattaswamy,
Philip-R-Beckwith,
ramkrishankumarN,
satya-nr and
mbolla22
kpattaswamy
reviewed
Jan 16, 2025
| @@ -131,3 +131,33 @@ nodeSelector: {} | |||
| tolerations: [] | |||
| # -- Sets all pods' affinities. Can be configured also with `global.affinity` | |||
| affinity: {} | |||
| # -- Kubernetes cluster domain | |||
There was a problem hiding this comment.
I believe you'll need to create new image & tags (need to use the dockerhub registry now since we are moving away from GCR) as well since the existing artifacts don't have the logic to utilize these configuration changes.
You'll also need to run helm-docs to auto-update the readme with the new changes from this Values.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ebpf-agent
Is this a new chart
What this PR does / why we need it:
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[mychartname])