Improve File Download Worker #13975
Open
Improve File Download Worker #13975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alperozturk96
changed the title
alperozturk96
force-pushed
the
improve-file-download-worker
branch
from
031a1b9 to
72f37a8
Compare
alperozturk96
commented
Jan 17, 2025
alperozturk96
commented
Jan 17, 2025
| @@ -25,17 +26,8 @@ class DownloadNotificationManager( | |||
| ) : WorkerNotificationManager(id, context, viewThemeUtils, R.string.downloader_download_in_progress_ticker) { | |||
|
|
|||
| @Suppress("MagicNumber") | |||
| fun prepareForStart(operation: DownloadFileOperation, currentDownloadIndex: Int, totalDownloadSize: Int) { | |||
There was a problem hiding this comment.
Since for each file new FileDownloadWork going to be scheduled, no need to track indexes.
alperozturk96
force-pushed
the
improve-file-download-worker
branch
2 times, most recently
from
af6aa74 to
02e216d
Compare
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
…name, do nothing. Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
alperozturk96
force-pushed
the
improve-file-download-worker
branch
from
5797cff to
ea45d7e
Compare
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13975.apk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Convert worker to CoroutineWorker
Call setForeground() before starting any task
Remove non-translatable texts
Remove total and current index tracking from DownloadNotificationManager. This feature can be reintroduced after addressing this issue. Refer to the Technical Explanation section for more details; without resolving this, the download status tracking feature is ineffective and nonfunctional.