Hard-code ignore files with prefix .trashed

[0ranki]

• Tests written, or not not needed

Creating initally as a draft. Help on how to write tests for this is most welcome, if necessary, as other comments too.

Fixes issue #10645 for people using Google Photos for handling their local copies of photos. Samsung Photos seems to use the same trashcan method too, though this hasn't been tried on a Samsung phone.

Files with the prefix .trashed are excluded from the list of files eligible for sync using the same method as is used for thumbnail files (hard-coded).

[tobiasKaminsky]

@alperozturk96 I have the same problem with ".nomedia".
I think this is because the logic of subfolder detection changed?

[0ranki]

@tobiasKaminsky @Aohzan Sure, I'll include .nomedia and .pending to the list. What app creates those .pending files, by the way?

[Aohzan]

@tobiasKaminsky @Aohzan Sure, I'll include .nomedia and .pending to the list. What app creates those .pending files, by the way?

For .pending, I think it's done by Google Photos, I don't have any other app relating with Camera dir 🤔 , I see some discussion about those files and people owning Pixel phones. I have the issue with two Pixel myself

[0ranki]

For .pending, I think it's done by Google Photos, I don't have any other app relating with Camera dir 🤔 , I see some discussion about those files and people owning Pixel phones. I have the issue with two Pixel myself

Ok, I have a Pixel too, but don't have Google stuff on it. Well, right now I do to test the trashcan stuff, but no sync to Google.

I did write a rudimentary unit test for the added hasExcludePrefix function, which isn't included yet. Should the branch be rebased to current master?

[tobiasKaminsky]

Thanks for your help!

I think this should also be added to SyncedFolderUtils -> isQualifiedFolder (L108), as then it ignores all folders with these names.

In my case, I only have an empty ".nomedia" folder, but no files in it.

What do you think?

[0ranki]

Thanks for your help!

I think this should also be added to SyncedFolderUtils -> isQualifiedFolder (L108), as then it ignores all folders with these names.

In my case, I only have an empty ".nomedia" folder, but no files in it.

What do you think?

I'd guess folders with those prefixes would be safe to ignore too, so .thumbdata could be added to the same list and the same function used for both

[0ranki]

SyncedFolderUtils -> hasExludePrefix is now used in SyncedFolderUtils -> isQualifiedFolder too.

Added a simple unit test.