Merge pull request #4250 from nextcloud/backport/4249/stable5.5

[stable5.5] fix: check if photo property is set before downloading
nextcloud · Jan 31, 2025 · badda52 · badda52
2 parents 80bec77 + fb69892
commit badda52
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/components/ContactsList/ContactsListItem.vue b/src/components/ContactsList/ContactsListItem.vue
@@ -116,7 +116,7 @@ export default {
 					return
 				}
 				this.avatarUrl = photoUrl
-			} else if (this.source.url) {
+			} else if (this.source.hasPhoto && this.source.url) {
 				this.avatarUrl = `${this.source.url}?photo`
 			}
 		},

diff --git a/src/models/contact.js b/src/models/contact.js
@@ -226,6 +226,16 @@ export default class Contact {
 		this.vCard.updatePropertyWithValue('photo', photo)
 	}
 
+	/**
+	 * Return whether a photo is available
+	 *
+	 * @readonly
+	 * @memberof Contact
+ 	 */
+	get hasPhoto() {
+		return this.dav && this.dav.hasphoto
+	}
+
 	/**
 	 * Return the photo usable url
 	 * We cannot fetch external url because of csp policies