fix: no selected message empty content misalignment #10587
Conversation
Signed-off-by: greta <[email protected]>
| @@ -52,7 +52,7 @@ export default { | |||
| } | |||
| .app-content { | |||
| display: flex; | |||
| height: 100%; | |||
| height: 100% !important; | |||
There was a problem hiding this comment.
is there a conflicting rule that set a different height?
There was a problem hiding this comment.
yes, the app-content-details, that breaks the message content.
There was a problem hiding this comment.
Wasn't that just added with 8089ccb?
This doesn't smell like a maintainable solution if the v-deep is leaking to places it shouldn't and we have to pull the !important overwrite to push back.
Would it be possible to get rid of the deep selector?
There was a problem hiding this comment.
Wasn't that just added with 8089ccb?
yes, thats what i linked on my first reply.
Its not that easy. My understanding is app-content-details shouldnt have the height:100%, but empty content should have it 100%.
I agree that we shouldnt force things, but i dont see how i can fix it differently. What i noticed now is that the style of .app-content-details is coming from contacts (!), which breaks our message content.
i have no idea why is this happening, need to investigate it better
There was a problem hiding this comment.
Is Contacts missing scoped for the component styles?
There was a problem hiding this comment.
it comes from a css file: https://github.com/nextcloud/contacts/blob/main/src/css/contacts.scss#L25
I dont see any vue component on contacts not to be scoped and has this class
There was a problem hiding this comment.
Can we move the css file into the app component that uses the lib component that is being styled?
|
close because its fixed on contacts nextcloud/contacts#4302 |
fixes #10586