Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(updatenotification): Parse pre-release version of apps #50233

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jan 17, 2025

Summary

The notification is correctly created, but the changelog is not show. We need to make sure the version passed to the manager is in the allowed format (major.minor.patch).

Checklist

@susnux susnux added this to the Nextcloud 31 milestone Jan 17, 2025
@susnux susnux requested review from JuliaKirschenheuter, Pytal, a team, ArtificialOwl, sorbaugh and come-nc and removed request for a team January 17, 2025 14:26
@susnux
Copy link
Contributor Author

susnux commented Jan 17, 2025

/backport to stable30

Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to adapt the @return tag and document bad request return code.

@Altahrim Altahrim mentioned this pull request Jan 21, 2025
@susnux susnux force-pushed the fix/update-notification branch from 5c42326 to 4b92dde Compare January 21, 2025 15:27
@susnux
Copy link
Contributor Author

susnux commented Jan 21, 2025

You need to adapt the @return tag and document bad request return code.

Thank you, done!

@susnux susnux force-pushed the fix/update-notification branch from 4b92dde to 0854abc Compare January 21, 2025 15:34
@susnux susnux requested a review from provokateurin as a code owner January 21, 2025 15:34
The notitication is correctly created, but the changelog is not show.
We need to make sure the version passed to the manager is in the allowed
format (major.minor.patch).

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux force-pushed the fix/update-notification branch from 0854abc to e212f33 Compare January 21, 2025 15:43
@susnux susnux merged commit 0a3cf3c into master Jan 21, 2025
189 checks passed
@susnux susnux deleted the fix/update-notification branch January 21, 2025 16:17
@Altahrim Altahrim mentioned this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants