Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vue3] fix: fix unmount issues and call reactivity #12461

Draft
wants to merge 5 commits into
base: vue3
Choose a base branch
from
Draft

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jun 5, 2024

☑️ Resolves

  • Reactivity doesn't work correctly for callParticipantModels, this leads to missed updates / re-renders, which worked in Vue2

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🚧 Tasks

  • replace ref with reactive
    • ⚠️ doesn't work deeply (or works, but flacky), if we push models later in the reactive array, and then update some properties null -> object (stream, peer, speaking)
  • Minor TypeErrors in console.log
  • Participant join with video
  • Participant join with screenshare (don't see)
  • Participant and speaking indicator (don't see)
  • Participant stops screenshare (main peer video is missing for several seconds)

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added this to the 💙 Next Major (30) milestone Jun 5, 2024
@Antreesy Antreesy requested a review from ShGKme June 5, 2024 14:51
@Antreesy Antreesy self-assigned this Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants