Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #3802 i have updated the packages #4050

Closed
wants to merge 1 commit into from
Closed

fix #3802 i have updated the packages #4050

wants to merge 1 commit into from

Conversation

subhanahujha007
Copy link

@subhanahujha007 subhanahujha007 commented Feb 25, 2024

fix #3802
list of updated packages:
chalk
minimist
mocha
open
selenium-webdriver
uuid

Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.

  • [x ] Create a new branch from master (e.g. features/my-new-feature or issue/123-my-bugfix);
  • [ x] If you're fixing a bug also create an issue if one doesn't exist yet;
  • [ x] If it's a new feature explain why do you think it's necessary. Please check with the maintainers beforehand to make sure it is something that we will accept. Usually we only accept new features if we feel that they will benefit the entire community;
  • [x ] Please avoid sending PRs which contain drastic or low level changes. If you are certain that the changes are needed, please discuss them beforehand and indicate what the impact will be;
  • [ x] If your change is based on existing functionality please consider refactoring first. Pull requests that duplicate code will most likely be ignored;
  • [ x] Do not include changes that are not related to the issue at hand;
  • [ x] Follow the same coding style with regards to spaces, semicolons, variable naming etc.;
  • [ x] Always add unit tests - PRs without tests are most of the times ignored.

@subhanahujha007 subhanahujha007 changed the title i have updated the packages fix #3802 i have updated the packages Feb 25, 2024
Copy link
Member

@vaibhavsingh97 vaibhavsingh97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@subhanahujha007 Please update the PR description with the updated packages; additionally, the PR is missing an updated 'package.json' file. Also, please use appropriate commit messages.

@nothuman2718
Copy link

nothuman2718 commented Feb 25, 2024

Brother. Can you explain what is this PR about and why?

@garg3133
Copy link
Member

@subhanahujha007 There's nothing to review in this PR. When you update the packages, there should be both a package.json and package-lock.json file present in your diff but you only have package-lock.json file there, that too migrated from lockVersion 2 to 3, which we don't want right now.

Also, you cannot just blindly update the packages, we need to be careful while updating them to make sure the new version does not break something.

@gravityvi
Copy link
Member

Closing this PR as it is missing information and looks irrelevant.

@gravityvi gravityvi closed this Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update JS dependencies
5 participants