-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REL: 2.4.0 #740
REL: 2.4.0 #740
Conversation
Codecov Report
@@ Coverage Diff @@
## master #740 +/- ##
==========================================
+ Coverage 88.36% 89.54% +1.17%
==========================================
Files 188 93 -95
Lines 23998 11470 -12528
Branches 4258 1991 -2267
==========================================
- Hits 21207 10271 -10936
+ Misses 2103 859 -1244
+ Partials 688 340 -348
Continue to review full report at Codecov.
|
@@ -207,6 +212,9 @@ | |||
"name": "Jordan, Kesshi", | |||
"orcid": "0000-0001-6313-0580" | |||
}, | |||
{ | |||
"name": "Cieslak, Matt" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattcieslak Let me know if you have another name you prefer for publications, your affiliation, and your ORCID. (Sorry if you've given this to me in another package, but I couldn't find it from a quick look.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here it is @effigies
{
"name": "Cieslak, Matthew",
"affiliation": "Department of Neuropsychiatry, University of Pennsylvania",
"orcid": "0000-0002-1931-4734"
},
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gah, just a few minutes too late! I'll have it in for the 2.4.1 release.
Preparation for nibabel release 2.4.0, targeting Monday, 25 March 2019.
The 2.4.0 milestone has been added for issues that should be addressed before a minor version release or pull requests that should be merged or deferred. Please add any issues or pull requests that need attention to the milestone or comment in this thread.
Issues/PRs that need to be addressed, merged or postponed
This is a partial list of the open PRs, based on my judgment of how close they are to ready or how likely the submitter is to still be active. If you think I've missed some, please let me know. I will try to update all of these issues/PRs, even if they don't get resolved this round.
Submitters: I would appreciate if all PRs could be merged or rebased with the current master.
Additional help pushing forward these issues or reviewing PRs would be very welcome.
I will merge #736 before releasing in the event of no reviews.
Pre-release checklist
doc/source/index.rst
and add any authors not yet acknowledged..mailmap file
if there are any duplicate authors listed fromgit shortlog -nse
.LONG_DESCRIPTION
ininfo.py
by runningmake refresh-readme
.nibabel/info.py
(e.g.NUMPY_MIN_VERSION
) and indoc/source/installation.rst
and inrequirements.txt
and.travis.yml
. They should at least match. Do they still hold? Make sure nibabel on travis is testing the minimum dependencies specifically.nosetests --with-doctest nibabel
nibabel/info.py
to set_version_extra
to''
; commitI'm skipping the build-bots, as they don't seem to buy us much that isn't in the CI. @matthew-brett Please let me know if there's a good reason to keep using them.
Adapted from http://nipy.org/nibabel/devel/make_release.html#release-checklist