Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REL: 2.4.0 #740

Merged
merged 9 commits into from
Apr 1, 2019
Merged

REL: 2.4.0 #740

merged 9 commits into from
Apr 1, 2019

Conversation

effigies
Copy link
Member

@effigies effigies commented Mar 15, 2019

Preparation for nibabel release 2.4.0, targeting Monday, 25 March 2019.

The 2.4.0 milestone has been added for issues that should be addressed before a minor version release or pull requests that should be merged or deferred. Please add any issues or pull requests that need attention to the milestone or comment in this thread.

Issues/PRs that need to be addressed, merged or postponed

This is a partial list of the open PRs, based on my judgment of how close they are to ready or how likely the submitter is to still be active. If you think I've missed some, please let me know. I will try to update all of these issues/PRs, even if they don't get resolved this round.

Submitters: I would appreciate if all PRs could be merged or rebased with the current master.

Additional help pushing forward these issues or reviewing PRs would be very welcome.

I will merge #736 before releasing in the event of no reviews.

Pre-release checklist

  • Review the open list of nibabel issues. Check whether there are outstanding issues that can be closed, and whether there are any issues that should delay the release. Label them!
  • Review and update the release notes. Review and update the Changelog file.
  • Look at doc/source/index.rst and add any authors not yet acknowledged.
  • Use the opportunity to update the .mailmap file if there are any duplicate authors listed from git shortlog -nse.
  • Check the copyright year in doc/source/conf.py
  • Refresh the README.rst text from the LONG_DESCRIPTION in info.py by running make refresh-readme.
  • Check the dependencies listed in nibabel/info.py (e.g. NUMPY_MIN_VERSION) and in doc/source/installation.rst and in requirements.txt and .travis.yml. They should at least match. Do they still hold? Make sure nibabel on travis is testing the minimum dependencies specifically.
  • Make sure all tests pass (from the nibabel root directory): nosetests --with-doctest nibabel
  • Edit nibabel/info.py to set _version_extra to ''; commit

I'm skipping the build-bots, as they don't seem to buy us much that isn't in the CI. @matthew-brett Please let me know if there's a good reason to keep using them.

Adapted from http://nipy.org/nibabel/devel/make_release.html#release-checklist

@effigies effigies added this to the 2.4.0 milestone Mar 15, 2019
@codecov-io
Copy link

codecov-io commented Mar 19, 2019

Codecov Report

Merging #740 into master will increase coverage by 1.17%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #740      +/-   ##
==========================================
+ Coverage   88.36%   89.54%   +1.17%     
==========================================
  Files         188       93      -95     
  Lines       23998    11470   -12528     
  Branches     4258     1991    -2267     
==========================================
- Hits        21207    10271   -10936     
+ Misses       2103      859    -1244     
+ Partials      688      340     -348
Impacted Files Coverage Δ
nibabel/info.py 100% <100%> (ø) ⬆️
nibabel/nicom/dicomwrappers.py 90.73% <0%> (-0.82%) ⬇️
nibabel/cifti2/cifti2.py 96.38% <0%> (-0.06%) ⬇️
nibabel/cifti2/__init__.py 100% <0%> (ø) ⬆️
nibabel/cifti2/parse_cifti2.py 83.76% <0%> (ø) ⬆️
venv/Lib/site-packages/nibabel/tripwire.py
venv/Lib/site-packages/nibabel/cmdline/nifti_dx.py
nibabel/cifti2/cifti2_axes.py
venv/Lib/site-packages/nibabel/brikhead.py
...nv/Lib/site-packages/nibabel/streamlines/header.py
... and 94 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a59f3b0...5319580. Read the comment docs.

.zenodo.json Outdated Show resolved Hide resolved
@@ -207,6 +212,9 @@
"name": "Jordan, Kesshi",
"orcid": "0000-0001-6313-0580"
},
{
"name": "Cieslak, Matt"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattcieslak Let me know if you have another name you prefer for publications, your affiliation, and your ORCID. (Sorry if you've given this to me in another package, but I couldn't find it from a quick look.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here it is @effigies

    {
      "name": "Cieslak, Matthew",
      "affiliation": "Department of Neuropsychiatry, University of Pennsylvania",
      "orcid": "0000-0002-1931-4734"
    },

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gah, just a few minutes too late! I'll have it in for the 2.4.1 release.

@effigies effigies merged commit 5319580 into master Apr 1, 2019
@effigies effigies deleted the rel/2.4.0 branch April 1, 2019 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants