Add support for hexadecimal and octal numbers #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I switched from `read` to our custom parsing because `read` expects
the `0o` prefix instead of C-style `0`.
We only handle integers for now, as `read` for `Double` does not support
decimal numbers with `0x` prefix and I did not want to implement decimals myself.
Additionally, add support for + sign.
Also merge `negative.settings` test file into `dconf.settings` since
that one aggregates configuration keys from real dconf dumps.
Instead create `numbers.settings` that tests all possible numeric values.
Currently unhandled cases:
zero-trailing=0.
zero-leading=.0
hex-float=0x10.1
GLib’s GVariant parses octal decimals a base 10.
This is probably expected, as the docs only mention hex floats.
oct-float=010.1
oct-sci=010e10
GLib’s GVariant parses the following as a double,
probably confusing it with scientific notation:
hex-neg-e=-0x1e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I switched from
readto our custom parsing becausereadexpects the0oprefix instead of C-style0. We only handle integers for now, asreadforDoubledoes not support decimal numbers with0xprefix and I did not want to implement decimals myself.Additionally, add support for + sign.
Also merge
negative.settingstest file intodconf.settingssince that one aggregates configuration keys from real dconf dumps. Instead createnumbers.settingsthat tests all possible numeric values.Currently unhandled cases:
GLib’s GVariant parses octal decimals a base 10. This is probably expected, as the docs only mention hex floats.
GLib’s GVariant parses the following as a double, probably confusing it with scientific notation: