Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Add WMF4 to build matrix in AppVeyor #44

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bergmeister
Copy link
Contributor

@bergmeister bergmeister commented Dec 18, 2018

Use WMF4 legacy image for testing. Although the image has been enabled, it does not seem to work, maybe it take a bit more time to be enabled.

@bergmeister bergmeister changed the title Add WMF4 to build matrix in AppVeyor WIP Add WMF4 to build matrix in AppVeyor Dec 18, 2018
@bergmeister
Copy link
Contributor Author

bergmeister commented Dec 18, 2018

@nohwnd The WMF 4 image is working now, we just need to make small adaptions for the way how Pester is being bootstrapped due to PowerShellGet and Packagemanagement not being fully available in PS v4. We could e.g. do a cinst Pester in the AppVeyor yaml for that or similar to how I do it in PSSA here
On an unrelated note: I have also requested here that Pester gets included in the next AppVeyor images.

@nohwnd
Copy link
Owner

nohwnd commented Dec 19, 2018

Sure, as long as it gets installed I don’t care how it got there :)

I saw that you asked them to include Pester, and I think I upvoted it. Thanks!

@bergmeister
Copy link
Contributor Author

bergmeister commented Dec 20, 2018

@nohwnd I fixed the Pester bootstrapping issue with the WMF 4 image but the results indicate that Assert or its tests need to be adapted for WMF4:

Tests Passed: 524, Failed: 109

@nohwnd
Copy link
Owner

nohwnd commented Dec 21, 2018

@bergmeister hmm that's weird, I remember it worked on PowerShell 2 and 5 and core, and 4 is not the weird kid in this bunch, v2 is. So I guess there is some oddity in PowerShell 4 that I don't know about (plausible), or something is wrong with the setup. I have a v4 vm, so I will test it after I pack all the christmas gifts (hopefully till 24th :D ). Thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants