This repository has been archived by the owner on May 4, 2024. It is now read-only.
chore: ci cleanup #111
Merged
chore: ci cleanup #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
wraithgar
commented
Sep 1, 2021
| }, | ||
| "dependencies": { | ||
| "delegates": "^1.0.0", | ||
| "readable-stream": "^2.0.6" | ||
| "readable-stream": "^3.6.0" |
There was a problem hiding this comment.
This semver major had to do w/ changes in node versions 9 and 10. Since 10 is already the minimum supported version for this repo this will only need to constitute a patch release.
jimmywarting
reviewed
Sep 1, 2021
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| node-version: [10.0.x, 10.x, 12.0.x, 12.x, 14.0.x, 14.x, 15.x, 16.x] |
There was a problem hiding this comment.
I feel like it's time to drop support for v10
it don't get security updates anymore
There was a problem hiding this comment.
Unfortunately we have to follow the npm cli on this for now. When we drop v10 there we can cascade that change down to all of its dependencies.
There was a problem hiding this comment.
As it happens, we will be discussing this very topic at today's RFC meeting! npm/rfcs#444
move to gh actions add npm linting fix tests for new tap
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move to gh actions
add npm linting
fix tests for new tap