Refactor config snapshot cleaning for ini comments

npm · Apr 12, 2024 · 983f8a5 · 983f8a5
1 parent fb9d47a
commit 983f8a5
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/test/lib/commands/config.js b/test/lib/commands/config.js
@@ -13,10 +13,15 @@ const replaceJsonOrIni = (key) => [
   `$1{${key.toUpperCase()}}`,
 ]
 
+const replaceIniComment = (key) => [
+  new RegExp(`(; ${key} = ).*`, 'g'),
+  `$1{${key.replaceAll(' ', '-').toUpperCase()}}`,
+]
+
 t.cleanSnapshot = (s) => cleanCwd(s)
-  .replaceAll(/(; node version = ).*/g, '$1{NODE-VERSION}')
-  .replaceAll(/(; npm version = ).*/g, '$1{NPM-VERSION}')
-  .replaceAll(/(; node bin location = ).*/g, '$1{EXECPATH}')
+  .replaceAll(...replaceIniComment('node version'))
+  .replaceAll(...replaceIniComment('npm version'))
+  .replaceAll(...replaceIniComment('node bin location'))
   .replaceAll(...replaceJsonOrIni('npm-version'))
   .replaceAll(...replaceJsonOrIni('viewer'))
   .replaceAll(...replaceJsonOrIni('shell'))