Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: log cache hits distinct from fetch #273

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Conversation

mbtools
Copy link
Contributor

@mbtools mbtools commented Oct 10, 2024

Avoid confusion between actual remote fetches and cache hits (which don't involve a fetch).

Ref npm/pacote#403 (comment)

@mbtools mbtools requested a review from a team as a code owner October 10, 2024 17:06
@wraithgar wraithgar changed the title chore: log cache hits distinct from fetch fix: log cache hits distinct from fetch Oct 14, 2024
@wraithgar
Copy link
Member

After sitting on this for awhile I think this is the right choice. The http loglevel indicates that at the highest level, the code is trying to get something via an http url. The logging verb then informs the end user what mechanism was actually used to retrieve the data (cache vs fetch).

@wraithgar wraithgar merged commit 8044781 into npm:main Oct 14, 2024
17 checks passed
@github-actions github-actions bot mentioned this pull request Oct 14, 2024
@mbtools mbtools deleted the log_cache_hits branch October 15, 2024 00:23
wraithgar pushed a commit that referenced this pull request Oct 16, 2024
🤖 I have created a release *beep* *boop*
---


##
[18.0.2](v18.0.1...v18.0.2)
(2024-10-16)
### Bug Fixes
*
[`8044781`](8044781)
[#273](#273) log cache
hits distinct from fetch (#273) (@mbtools)
### Chores
*
[`99b99d2`](99b99d2)
[#269](#269) bump cacache
from 18.0.4 to 19.0.1 (#269) (@dependabot[bot])
*
[`bd3f7d1`](bd3f7d1)
[#272](#272) bump
@npmcli/template-oss from 4.23.3 to 4.23.4 (#272) (@dependabot[bot],
@npm-cli-bot)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants