fix(linter): dependency-check-support-catalogs #29923
Merged
+136
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
ryanbas21
force-pushed
the
support-catalogs-dependency-check
branch
2 times, most recently
from
c41b290 to
f38671d
Compare
This was referenced Feb 11, 2025
|
View your CI Pipeline Execution ↗ for commit b64ab8b. ☁️ Nx Cloud last updated this comment at |
|
Thanks @ryanbas21 this PR looks good overall. We can use this to fix #29959 as well. I can check it out and make minor changes to ensure both issues are addressed. |
…orkspace protocol added support in dependency check lint rule to check for named and unnamed catalogs also added rest of workspace protocol closed nrwl#29903
jaysoo
force-pushed
the
support-catalogs-dependency-check
branch
from
f38671d to
b64ab8b
Compare
|
I pushed an update, once the CI is green I'll merge. Thanks again. |
jaysoo
approved these changes
Feb 11, 2025
|
Not sure why the 1 pending check is still showing as pending. The last CI run ran successfully so I'll merge it: https://staging.nx.app/cipes/67aba57ab4efc06ae52cea88 |
jaysoo
added a commit
that referenced
this pull request
Feb 12, 2025
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior Currently there doesn't seem to be support for pnpm catalogs in the dependency check which throws an error. ## Expected Behavior Catalog should be supported and at least not throw an error since its a default rule in some generators. I noticed that also that only `workspace:*` was implemented so I added the other possible options. https://pnpm.io/workspaces#publishing-workspace-packages I copy and pasted a test twice to add tests for this. I mean ideally I guess we would check the `pnpm-workspace` file and say is this catalog defined, I don't think that's up my ally for this purpose and I'm not sure if how its implemented does that for the workspace protocols as well. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # closed #29903, #29959 Gave it a shot, not sure if this is gonna be comprehensive enough. But let me know! happy to try and get this right. --------- Co-authored-by: Jack Hsu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Currently there doesn't seem to be support for pnpm catalogs in the dependency check which throws an error.
Expected Behavior
Catalog should be supported and at least not throw an error since its a default rule in some generators.
I noticed that also that only
workspace:*was implemented so I added the other possible options.https://pnpm.io/workspaces#publishing-workspace-packages
I copy and pasted a test twice to add tests for this.
I mean ideally I guess we would check the
pnpm-workspacefile and say is this catalog defined, I don't think that's up my ally for this purpose and I'm not sure if how its implemented does that for the workspace protocols as well.Related Issue(s)
Fixes #
closed #29903, #29959
Gave it a shot, not sure if this is gonna be comprehensive enough. But let me know! happy to try and get this right.