Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix finalize changelog #1250

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Fix finalize changelog #1250

wants to merge 7 commits into from

Conversation

sandrofigo
Copy link
Contributor

@sandrofigo sandrofigo commented Sep 1, 2023 •
edited
Loading

This PR fixes the wrong behavior when calling FinalizeChangelog() where the version summary would be repeated, as seen here.
A unit test has been added to confirm the behavior.

I confirm that the pull-request:

  • Follows the contribution guidelines
  • Is based on my own work
  • Is in compliance with my employer

@sandrofigo sandrofigo mentioned this pull request Sep 1, 2023
Merged
3 tasks
@sandrofigo sandrofigo force-pushed the fix-finalize-changelog branch 3 times, most recently from 0994b8b to 5cf2f18 Compare September 5, 2023 06:55
@sandrofigo sandrofigo mentioned this pull request Sep 5, 2023
Open
3 tasks
@sandrofigo
Copy link
Contributor Author

@matkoch This should fix the parsing problem when finalizing the changelog as discussed in #1130

@matkoch matkoch force-pushed the develop branch 5 times, most recently from 0231425 to d806295 Compare December 15, 2023 23:12
@matkoch matkoch force-pushed the develop branch 3 times, most recently from 7066bbe to 985de83 Compare January 17, 2024 17:25
@sandrofigo sandrofigo force-pushed the fix-finalize-changelog branch from 5cf2f18 to 6f55aaf Compare March 4, 2024 07:31
@matkoch matkoch force-pushed the develop branch 4 times, most recently from 0719711 to 6fe1e3b Compare March 20, 2024 01:24
@matkoch matkoch force-pushed the develop branch 2 times, most recently from 6d02194 to 4bfee84 Compare June 13, 2024 21:33
@matkoch matkoch force-pushed the develop branch 3 times, most recently from 85998da to 01b2b6e Compare July 9, 2024 00:20
@matkoch matkoch force-pushed the develop branch 3 times, most recently from e652c9a to 6ed9e4d Compare July 14, 2024 18:27
@matkoch matkoch force-pushed the develop branch 2 times, most recently from df620ac to 482f5ac Compare November 26, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sandrofigo @matkoch