Also support codefix for .Within #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manfred-brands
approved these changes
Dec 31, 2023
There was a problem hiding this comment.
@Laniusexcubitor Thanks for your contribution.
I have made some tiny changes.
One to ensure that the test validates that the correct parameter is swapped.
The other because I'm pedantic and don't like abbreviated variable names.
| public void Test() | ||
| {{ | ||
| int expected = 5; | ||
| ClassicAssert.{classicAssertMethod}(expected, ↓1, 1); |
There was a problem hiding this comment.
It is never good to use two arguments with the same value as it doesn't proof that the correct argument is exchanged.
I have update the code to use double.Epsilon for the accuracy.
Comment on lines
160
to
166
| if (invocationExpression.Expression is not MemberAccessExpressionSyntax mae) | ||
| { | ||
| memberAccessExpression = null; | ||
| return false; | ||
| } | ||
|
|
||
| memberAccessExpression = mae; |
There was a problem hiding this comment.
I simplified this a tiny bit. Mainly because I don't like shorthand names like mae
| if (memberAccessExpression.Name.ToString() == NUnitFrameworkConstants.NameOfEqualConstraintWithin) | ||
| { | ||
| // e.g. Is.EqualTo(1).Within(1) or Is.Not.EqualTo(1).Within(1) | ||
| if (memberAccessExpression.Expression is not InvocationExpressionSyntax ies |
There was a problem hiding this comment.
Renamed ies into innerInnovationExpression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #669