Remove null message in AreEqual code fix #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` Assert.AreEqual(2d, 3d, null); ``` would generate ``` Assert.That(3d, Is.EqualTo(2d), null); ``` which does not compile ``` The call is ambiguous between the following methods or properties: 'Assert.That<TActual>(TActual, IResolveConstraint, FormattableString, string, string)' and 'Assert.That<TActual>(TActual, IResolveConstraint, Func<string>, string, string)' ```
manfred-brands
requested changes
Mar 4, 2024
Comment on lines
58
to
63
| // Remove null message to avoid ambiguous calls. | ||
| if (arguments.Count == 3 && arguments[2].Expression.Kind() == SyntaxKind.NullLiteralExpression) | ||
| { | ||
| arguments.RemoveAt(2); | ||
| } | ||
|
|
There was a problem hiding this comment.
This needs to move after the call to UpdateArguments below so that it also works if there is a tolerance value specified.
| @@ -56,6 +56,22 @@ public void TestMethod() | |||
| RoslynAssert.CodeFix(analyzer, fix, expectedDiagnostic, code, fixedCode, fixTitle: ClassicModelAssertUsageCodeFix.TransformToConstraintModelDescription); | |||
| } | |||
|
|
|||
| [Test] | |||
| public void VerifyAreEqualFixWithNullMessage() | |||
There was a problem hiding this comment.
Please add another test with a tolerance value: ClassicAssert.AreEqual(2d, 3d, 0.1, null);
| @@ -55,6 +55,12 @@ public sealed override async Task RegisterCodeFixesAsync(CodeFixContext context) | |||
| // Now, replace the arguments. | |||
| List<ArgumentSyntax> arguments = invocationNode.ArgumentList.Arguments.ToList(); | |||
|
|
|||
| // Remove null message to avoid ambiguous calls. | |||
| if (arguments.Count == 3 && arguments[2].Expression.Kind() == SyntaxKind.NullLiteralExpression) | |||
There was a problem hiding this comment.
Suggested change
| if (arguments.Count == 3 && arguments[2].Expression.Kind() == SyntaxKind.NullLiteralExpression) | |
| if (arguments.Count == 3 && arguments[2].Expression.IsKind(SyntaxKind.NullLiteralExpression)) |
manfred-brands
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #700
would generate
which does not compile