Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of closure and record #68

Merged
merged 3 commits into from
Jan 12, 2024

Conversation

kit494way
Copy link
Contributor

Fix #67
Fix #16
Fix #65

This change makes it possible to parse closure without parameter pipes.
And following types are parsed as record key

  • unquoted string contains a hyphen
  • number
  • variable
  • subexpression

@fdncred
Copy link
Collaborator

fdncred commented Jan 12, 2024

wow, this is great! thanks for fixing those long-standing issues!

@fdncred fdncred merged commit 574fc62 into nushell:main Jan 12, 2024
3 checks passed
@kit494way kit494way deleted the fix-parsing-closure-record branch February 3, 2024 06:13
mrdgo pushed a commit to mrdgo/tree-sitter-nu that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Closure parsed as a record Some record keys are not parsed correctly blocks cannot be used as values
2 participants