Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: narrow legacy or composition vue-i18n types #3341

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BobbieGoede
Copy link
Collaborator

@BobbieGoede BobbieGoede commented Feb 2, 2025

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This also prepares the types for the additional narrowing possible with intlify/vue-i18n#2094 in vue-i18n v11 and up.

Not sure if these changes https://github.com/nuxt-modules/i18n/pull/3341/files#diff-6651fe35cf71a075f9059641cd99a6d6a927b2cb77ab2a0b494eacf46735fe52R64-R70 are correct. It unwraps the extended property refs, but I'm not sure if these are the appropriate instances that need the unwrapped properties to match legacy and global component property types.

📝 Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@BobbieGoede BobbieGoede self-assigned this Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant