Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use @nuxt/ui for examples #63

Merged
merged 5 commits into from
Dec 13, 2023

Conversation

arashsheyda
Copy link
Member

@arashsheyda arashsheyda commented Dec 11, 2023

refactored the code from old @nuxt/devtools-ui to @nuxt/ui

  • moved all the examples udner a sub directory called examples (the goal was to have a cleaner directory structure, if it's not a good idea we can revert that)
  • add @nuxt/examples-ui for shared ui usages udner shared directory
  • currently, auth is not in .docs, should we add that?

NuxtLayoutExample looks like this: (I can record all the examples if needed to see how they look like)

Screen.Recording.2023-12-11.at.11.35.01.AM.mov

resolves #59

Copy link

vercel bot commented Dec 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2023 10:04am

@arashsheyda
Copy link
Member Author

also rn the examples are using the shared ui (@nuxt/examples-ui) like this, would this work on stackblitz?

  "devDependencies": {
    "@nuxt/examples-ui": "workspace:*",
    "nuxt": "^3.8.1"
  }

@atinux
Copy link
Member

atinux commented Dec 12, 2023

I think I will have to publish on npm the package @arashsheyda

@arashsheyda
Copy link
Member Author

okay thanks :D

@atinux
Copy link
Member

atinux commented Dec 12, 2023

https://www.npmjs.com/package/@nuxt/examples-ui

Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to go - see https://examples-6makfan46-nuxt-js.vercel.app/?force=local-auth for example.

@danielroe
Copy link
Member

(One note: we may need to update the e2e tests...)

@danielroe
Copy link
Member

danielroe commented Dec 13, 2023

let's merge #45 first (I'll finish it off) and then confirm all working with this PR

@danielroe danielroe changed the title refactor!: nuxt ui refactor: use @nuxt/ui for examples Dec 13, 2023
@danielroe danielroe merged commit 9f3d7cf into nuxt:main Dec 13, 2023
1 check passed
@arashsheyda arashsheyda deleted the refactor/nuxt-ui branch December 13, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs example stackblitz projects are missing components
3 participants