Fix tinted-theming/base16-vim support due to rename #1346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `tinted-theming/base16-vim` repository has been renamed to `tinted-theming/tinted-vim`, and the internal colour names have been renamed from `base16_gui*` to `tinted_gui*`. This caused Lualine to print a warning error when using tinted-vim. This pull updates the colour names to what `tinted-theming`now uses. I've also renamed the `setup_base16_vim()` function to `setup_tinted_vim()` for consistency.
Updated `THEMES.md` to refer to `tinted-theming/tinted-vim` rather than the older name of `tinted-theming/base16-vim` (which now silently redirects to `tinted-theming/tinted-vim`).
|
I mentioned in a duplicate PR:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The support for
tinted-theming/base16-vimwas broken becausetinted-theminghave renamed that repository totinted-theming/tinted-vim.Most importantly, the internal variables for their base16 colorschemes have changed from
base16_gui*totinted_gui*, which meant that lualine's checking functions had stopped working.This fixes the
tinted-theming/tinted-vimdetection, renames the setup function tosetup_tinted_vim(), and fixes the link in the THEMES.md documentation to point to the new repository name.