Fix range-rate calculation in azimuth_elevation_range_sez #382
+325
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was already the case for ephemeris validation. Also update the validation earth_latest_high_prec.bpc file
Unique names for artifact upload v4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Important bug fix: the range-rate computation was incorrect because the formulation in the range-rate calculation did not account for the fact that the receiver was already expressed in the transmitter's frame.
Also add the attempt to compute the time derivative of the SEZ frame, but that will usually fail (cf. function documentation).
Architectural Changes
fromparameter in the topocentric DCM Orbit method is no longer used; instead the same approach as in the other DCM methods is used. This will simplify the signature for version 0.6.0.New Features
No change
Improvements
No change
Bug Fixes
Fix #381
Testing and validation
Migrated the topocentric measurement validation from Nyx into ANISE; that test did not export the azimuth and elevation, nor did I save the ephemeris used. There is some difference in the range calculation between GMAT and ANISE, but given the extensive validation of the ephemerides and the excellent accuracy of the range-rate (less than 1 m/s error), I strongly believe the difference is simply a configuration difference.
Documentation
This PR does not primarily deal with documentation changes.