Skip to content
This repository has been archived by the owner on Nov 23, 2021. It is now read-only.

Code cleanup / adding JavaDoc #485

Closed
wants to merge 10 commits into from
Closed

Code cleanup / adding JavaDoc #485

wants to merge 10 commits into from

Conversation

sroeger
Copy link

@sroeger sroeger commented Sep 1, 2016 •
edited
Loading

This PR does several changes demanded in #392. This includes

  • resolving / creating issues concerning code markers TODO and REVIEW
    • added a default status for PaymentStatus
    • added check for sidedishState and mealState (this includes some minor changes in the sql script and related entity/eto)
    • added test for not allowed change of a ProductOrderState in SalesManagementTest
  • adds JavaDocs (also for CobiGen generated test data builders - I created a PR so these builders will include JavaDoc automatically)
  • formatting was done automatically

@oasp-ci
Copy link
Collaborator

oasp-ci commented Sep 1, 2016

Can one of the admins verify this patch?

@sroeger sroeger mentioned this pull request Sep 1, 2016
Closed
@hohwille
Copy link
Member

Can someone resolve the conflicts?

@jomora jomora added the easyfix label Sep 22, 2016
@jomora jomora self-assigned this Sep 22, 2016
@hohwille hohwille added this to the oasp:2.2.0 milestone Sep 22, 2016
@kiran-vadla
Copy link
Contributor

@jomora , Just to remind on this PR.

@kiran-vadla kiran-vadla self-assigned this Dec 7, 2016
kiran-vadla
kiran-vadla approved these changes Dec 8, 2016
View reviewed changes
Copy link
Contributor

@kiran-vadla kiran-vadla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the code . Looks OK.

@kiran-vadla
Copy link
Contributor

I have reviewed and merged this pull request.

@kiran-vadla kiran-vadla closed this Dec 9, 2016
@hohwille
Copy link
Member

Funny. It seems that this PR was actually not merged but simply closed. I just redid the same changes again. Sad waste...

@hohwille
Copy link
Member

See PR #629

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kiran-vadla kiran-vadla kiran-vadla approved these changes

Assignees

@jomora jomora

@kiran-vadla kiran-vadla

Labels
easyfix
Projects
None yet
Milestone
oasp:2.2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@sroeger @oasp-ci @hohwille @kiran-vadla @jomora