-
Notifications
You must be signed in to change notification settings - Fork 302
OASP4J 2.5.0 database integrations issue #635
Conversation
Do not recreate Collection declared as Iterable has it is already a Collection
@sjimenez77 @vapadwal |
So If we are actually planning a bugfix release for that, this should actually be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vapadwal thanks for the change. Fix looks right. I rebased it to new develop-2.5 branch that I created fresh from 2.5.0 tag. Please consider this for future PRs in advance.
Travis failed with:
So for some strange reason travis uses a new version of spring-boot-maven-plugin without any change from us related to that. This is the same error that I had with #629 and fixed by adding the plugin to the dependency-management of the archetype pom. |
@hohwille thanks for reviewing my PR, I have few questions,
|
Added the label invalid and discontinued as this PR is not required, its already taken care in release 2.6.0 |
No description provided.