Skip to content
This repository has been archived by the owner on Nov 23, 2021. It is now read-only.

OASP4J 2.5.0 database integrations issue #635

Closed
wants to merge 6 commits into from
Closed

OASP4J 2.5.0 database integrations issue #635

wants to merge 6 commits into from

Conversation

vapadwal
Copy link
Contributor

No description provided.

@maybeec
Copy link
Member

maybeec commented Feb 28, 2018

@sjimenez77 @vapadwal
this should go into the bugfix release, shouldn't it? Please note such crucial things in the comments to make it easy for the release manager to finally bring it onto the right branches. As we are starting to establish more dedicated component responsibilities, we should not provide PRs with implicit communication over offline channels.

@sjimenez77
Copy link
Contributor

I fully agree with @maybeec. Please @vapadwal elaborate a bit more the description of this PR. Thanks!

@hohwille
Copy link
Member

hohwille commented Mar 2, 2018

So 2.5.0 has already been released.
http://repo1.maven.org/maven2/io/oasp/java/modules/oasp4j-jpa/2.5.0/

If we are actually planning a bugfix release for that, this should actually be 2.5.1 - right? I will create branch and milestone then.

@hohwille hohwille added this to the oasp:2.5.1 milestone Mar 2, 2018
@hohwille hohwille changed the base branch from develop to develop-2.5 March 2, 2018 17:05
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vapadwal thanks for the change. Fix looks right. I rebased it to new develop-2.5 branch that I created fresh from 2.5.0 tag. Please consider this for future PRs in advance.

@hohwille
Copy link
Member

hohwille commented Mar 2, 2018

Travis failed with:

[INFO] Caused by: java.lang.UnsupportedClassVersionError: org/springframework/boot/maven/RepackageMojo : Unsupported major.minor version 52.0

So for some strange reason travis uses a new version of spring-boot-maven-plugin without any change from us related to that. This is the same error that I had with #629 and fixed by adding the plugin to the dependency-management of the archetype pom.
@vapadwal could you cherry pick my fix from #629 (you can manually copy it - see dfe298e) to your fork please.

@vapadwal
Copy link
Contributor Author

vapadwal commented Mar 8, 2018

@hohwille thanks for reviewing my PR, I have few questions,

  1. For bugfix release my understanding is we should release from 2.5.1 and after release is done then merge 2.5.1 to master and develop.
  2. There are few commits other than mine one, do we need those fixes also e.g. fixes from mathieu-lavigne
  3. If we are not including fixes from mathieu-lavigne. Should I close this PR and create new one that would only contain 2 fixes
    1} spring-boot-starter-data-jpa and 2)fixes for travis spring-boot-maven-plugin.
  4. For fix of travis, I have put spring-boot-maven-plugin in oasp4j/pom.xml and in templates/server/src/main/resources/pom.xml

@hohwille hohwille removed this from the oasp:2.5.1 milestone Jun 18, 2018
@vapadwal
Copy link
Contributor Author

vapadwal commented Jun 19, 2018

Added the label invalid and discontinued as this PR is not required, its already taken care in release 2.6.0
Closing this PR

@vapadwal vapadwal closed this Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants