Add a Compare module to the standard library #13755
Open
+87
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First proposed in #13753 (comment)
As previously extensively discussed in #9928, #9080 and in many tickets or forum posts, both the physical equality operator
==
and the polymorphic comparison functionscompare
and=
are known footguns for OCaml developers of all levels.Similarly to #9080 / #13753, this PR hopes to be a first step towards a world where OCaml does not have this footgun anymore by encouraging people to use functions from this new module (which is more explicit than using it directly from
Stdlib
and thus less prone to footgunning), then deprecating==
,compare
, … when they are less used.Note for reviewers: i'll add documentation to the functions once/if the interface is agreed