Update main with upstream main #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CKAN 2.9.6 introduced a security change in the way Repoze auth cookies are set up. Previously the user identifier was the user name, but that has been changed to the user internal id plus a serial autoincrement (currently static). As ckanext-saml2auth calls the `set_repoze_user` directly we need to update what gets passed to be stored in the cookie, otherwise the user will never be logged in. Previous versions should keep using the user name to avoid the same problem. Note that all this will no longer be relevant on CKAN 2.10 as it uses a completely different login system.
Fix broken login in CKAN>=2.9.6
Enable Python 3.9 tests in CI
Bump Github action versions
CKAN 2.10 support
This reverts commit 17a5078.
From the upstream tests, it was found that sometimes there may not be a user
Since I can't diagnose the python 3.9 issue locally, I just want to see if it's a python 3.9 specific issue, or if there is something else going wrong
Tested locally with python 3.9 and ckan 2.10.
Audit authentication events
Check https://github.com/IdentityPython/pysaml2/releases/tag/v7.4.0 Error I saw: ``` from ckanext.saml2auth.client import Saml2Client File "/__w/ckanext-unhcr/ckanext-unhcr/ckanext-saml2auth/ckanext/saml2auth/client.py", line 19, in <module> from saml2.client import Saml2Client File "/usr/lib/python3.8/site-packages/pysaml2-7.4.0-py3.8.egg/saml2/__init__.py", line 432, in <module> class SamlBase(ExtensionContainer): File "/usr/lib/python3.8/site-packages/pysaml2-7.4.0-py3.8.egg/saml2/__init__.py", line 442, in SamlBase c_child_order: list[str] = [] TypeError: 'type' object is not subscriptable ```
pysqml2 7.4 requires python 3.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syncing this repo