Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve authentication scripts #136

Merged
merged 1 commit into from
Jan 21, 2024

Conversation

AstreaTSS
Copy link
Contributor

This PR improves the authentication scripts by doing two things:

  • Refactor the scripts to use aiohttp.web instead of sanic. sanic is not a required package for aiogoogle as a whole while aiohttp is, so this makes it a bit more convenient for people to use these scripts.
    • That being said, pyyaml is still required despite it not being required for aiogoogle. Maybe consider using JSON files instead?
  • Make the scripts immediately exit out if pyyaml isn't detected.

@omarryhan
Copy link
Owner

Thank you very much!

@omarryhan omarryhan merged commit 1adfda4 into omarryhan:master Jan 21, 2024
11 checks passed
@AstreaTSS AstreaTSS deleted the improve-auth-scripts branch February 2, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants