Merge the adapter and platform enums into one generic backend enum. #2377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
loader
|
LLVM PR intel/llvm#16173 |
RossBrunton
approved these changes
Nov 26, 2024
kbenzie
reviewed
Dec 6, 2024
| @@ -560,6 +560,21 @@ typedef struct ur_rect_region_t { | |||
|
|
|||
| } ur_rect_region_t; | |||
|
|
|||
| /////////////////////////////////////////////////////////////////////////////// | |||
| /// @brief Defines known backends. | |||
| typedef enum ur_backend_t { | |||
There was a problem hiding this comment.
I wonder if it might smooth the transition to have aliases to the old names for the two enums?
I assume the numerical values are the same so its just a source change.
There was a problem hiding this comment.
we're at the point now where the next release this makes it into is a major one, I think we just rip the bandaid off
Bensuo
approved these changes
Dec 17, 2024
aarongreig
force-pushed
the
aaron/mergeAdapterPlatformBackend
branch
3 times, most recently
from
8a8dcc8 to
f9b9aff
Compare
aarongreig
force-pushed
the
aaron/mergeAdapterPlatformBackend
branch
from
f9b9aff to
9f11e28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.