Add umf benchmarks: preloaded umfProxy #2563
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbalcer
reviewed
Jan 15, 2025
scripts/benchmarks/benches/umf.py
Outdated
| def __init__(self, bench): | ||
| super().__init__(bench) | ||
|
|
||
| self.lib_to_be_replaced = "glibc" |
There was a problem hiding this comment.
looks like these should be constructor arguments.
scripts/benchmarks/benches/umf.py
Outdated
|
|
||
| def bin_args(self): | ||
| full_args = super().bin_args() | ||
| full_args.append("--benchmark_filter=glibc") |
There was a problem hiding this comment.
Suggested change
| full_args.append("--benchmark_filter=glibc") | |
| full_args.append(f"--benchmark_filter={self.lib_to_be_replaced}") |
?
EuphoricThinking
force-pushed
the
benchmark_patch_umf_preload
branch
from
f3b70c2 to
bb41efc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend UMF benchmarks with a base class for preloaded benchmarks and umfProxy benchmark.