Skip to content

Commit

Permalink
ci: install Python the same way everywhere
Browse files Browse the repository at this point in the history
For wheel builds, we shouldn't create a virtualenv, as it conflicts
with the check phase
  • Loading branch information
vlaci committed Feb 1, 2025
1 parent ee5ff66 commit 740da88
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 7 deletions.
4 changes: 4 additions & 0 deletions .github/actions/setup-dependencies/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,3 +39,7 @@ runs:
- name: Install the project
run: uv sync
shell: bash

- name: Setup pip # some tools need it, and uv virtualenvs doesn't contain it
run: uv pip install pip
shell: bash
13 changes: 6 additions & 7 deletions .github/workflows/CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,6 @@ jobs:
- name: Checkout source code
uses: actions/checkout@v4

- name: Setup Python
uses: actions/setup-python@v5

- name: Setup 3rd party dependencies
uses: ./.github/actions/setup-dependencies
with:
Expand Down Expand Up @@ -129,9 +126,10 @@ jobs:
- name: Checkout source code
uses: actions/checkout@v4

- uses: actions/setup-python@v5
- name: Setup 3rd party dependencies
uses: ./.github/actions/setup-dependencies
with:
python-version: 3.x
install-test-deps: "false"

- name: Build wheels
uses: PyO3/maturin-action@v1
Expand Down Expand Up @@ -221,9 +219,10 @@ jobs:
- name: Checkout source code
uses: actions/checkout@v4

- uses: actions/setup-python@v5
- name: Setup 3rd party dependencies
uses: ./.github/actions/setup-dependencies
with:
python-version: 3.x
install-test-deps: "false"

- name: Build wheels
uses: PyO3/maturin-action@v1
Expand Down

0 comments on commit 740da88

Please sign in to comment.