Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish version v0.1.25-linux #1117

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Publish version v0.1.25-linux #1117

wants to merge 1 commit into from

Conversation

Kitenite
Copy link
Contributor

Description

What is the purpose of this pull request?

  • New feature
  • Documentation update
  • Bug fix
  • Refactor
  • Release
  • Other

@Kitenite Kitenite marked this pull request as draft January 27, 2025 04:34
@JonCastaway
Copy link

JonCastaway commented Jan 27, 2025

Will this release fix the oauth issue when using github? (When the conflicts are resolved). On the previous branch, the app (deb) binary worked other than when using the github oauth to sign in it doesn't proceed any further.

@Kitenite
Copy link
Contributor Author

@JonCastaway , it seems the oauth issue is due to the redirect not working we're expecting onlook://auth to be able to redirect to the app to pass back the auth tokens. This doesn't seem to be the case in Linux. What would the protocol be for it to work? Perhaps the app is incorrectly named for Linux?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants