feat: implement node-gyp wrapper for native module compilation #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
- Add node-gyp wrapper script to use electron's node for npm commands - Configure electron-builder with CommonJS format (.cjs) - Add cross-platform support for node binary paths - Include wrapper script in electron-builder resources Co-Authored-By: [email protected] <[email protected]>
Co-Authored-By: [email protected] <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node-gyp Wrapper Implementation
This PR implements a node-gyp wrapper to enable running node-gyp npm commands using Electron's built-in Node runtime, focusing on node-pty compilation.
Changes
Implementation Details
process.execPathto ensure consistent Node binary usageTesting Status
Next Steps
Link to Devin run: https://app.devin.ai/sessions/a041e99365054fb2b8eff10bb1a73600