New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: pass port spec from localhost URL to run script #1186

Open

devin-ai-integration wants to merge 1 commit into main from devin/1738306048-pass-port-env

Contributor

devin-ai-integration bot commented Jan 31, 2025

Implements logic for environment variable/CLI-based port setting

This PR adds support for:

Extracting port numbers from localhost URLs (e.g., localhost:3000)
Setting PORT environment variable from command prefix (e.g., PORT=3001)
Setting PORT from CLI arguments (e.g., -- -p 3001)

Changes:

Added port extraction logic in RunManager.startTerminal
Updated terminal and process managers to support environment variables
Added type safety improvements for process handling
Created test suite for port extraction scenarios

Testing:

Added unit tests for all port specification formats
Verified backward compatibility with existing commands
Ensured environment variables are properly passed to child processes

Link to Devin run: https://app.devin.ai/sessions/7728656c611f4a75927d74c6f7fc693b


          feat: pass port spec from localhost URL to run script

011f5c2

Co-Authored-By: [email protected] <[email protected]>

Contributor Author

devin-ai-integration bot commented Jan 31, 2025

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
Look at CI failures and help fix them

⚙️ Control Options:

Disable automatic comment and CI monitoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet