Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update simple-user.ts #1101

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update simple-user.ts #1101

wants to merge 1 commit into from

Conversation

padgad336
Copy link

Title:

Change session from private to public for ringback tone usage

Description:

This PR modifies the session visibility from private to public to enable its usage for ringback tone functionality. Additionally, improvements were made to the remote media setup to ensure smoother playback.

Changes made:

Updated session access level from private → public. Improved setupRemoteMediaSimpleUserRingBackTone function for better handling of media playback. Updated Code:
typescript

 if (simpleUser?.session?.earlyMedia) {
     
      setupRemoteMediaSimpleUserRingBackTone(simpleUser?.session, mediaElement);
    }
async function setupRemoteMediaSimpleUserRingBackTone(session: Session, mediaElement: HTMLMediaElement) {
  try {
    if (!mediaElement) {
      console.error("Media element is not provided");
      return;
    }

    const pc = session?.sessionDescriptionHandler?.peerConnection; //SimpleUser?.session
    if (!pc) {
      console.error("PeerConnection not found in session");
      return;
    }

    let remoteStream: MediaStream | null = null;

    if (pc.getReceivers) {
      remoteStream = new MediaStream();
      pc.getReceivers().forEach((receiver) => {
        if (receiver.track) {
          remoteStream!.addTrack(receiver.track);
        }
      });
    } else if (pc.getRemoteStreams) {
      remoteStream = pc.getRemoteStreams()[0] || null;
    }

    if (!remoteStream) {
      console.warn("No remote stream found");
      return;
    }

    mediaElement.srcObject = remoteStream;

    if (mediaElement.paused) {
      try {
        await mediaElement.play();
      } catch (error) {
        console.warn("Autoplay blocked, retrying...");
        setTimeout(async () => {
          try {
            await mediaElement.play();
          } catch (err) {
            console.error("Error playing media:", err);
          }
        }, 1000);
      }
    }
  } catch (error) {
    console.error("Error in setupRemoteMediaSimpleUserRingBackTone:", error);
  }
}

Reason for change:
The previous private session restricted access, making it impossible to utilize the session for ringback tone playback. By setting it to public, the session can now be used as intended. Additionally, the media setup function has been improved to ensure stability and better error handling.

Impact:
Allows the session to be accessible for ringback tone. Ensures proper media playback and prevents unnecessary errors.

Title:
Change session from private to public for ringback tone usage

Description:
This PR modifies the session visibility from private to public to enable its usage for ringback tone functionality. Additionally, improvements were made to the remote media setup to ensure smoother playback.

Changes made:
Updated session access level from private → public.
Improved setupRemoteMediaSimpleUserRingBackTone function for better handling of media playback.
Updated Code:
typescript
```ts
async function setupRemoteMediaSimpleUserRingBackTone(session: any, mediaElement: HTMLMediaElement) {
  try {
    if (!mediaElement) {
      console.error("Media element is not provided");
      return;
    }

    const pc = session?._sessionDescriptionHandler?._peerConnection;
    if (!pc) {
      console.error("PeerConnection not found in session");
      return;
    }

    let remoteStream: MediaStream | null = null;

    if (pc.getReceivers) {
      remoteStream = new MediaStream();
      pc.getReceivers().forEach((receiver) => {
        if (receiver.track) {
          remoteStream!.addTrack(receiver.track);
        }
      });
    } else if (pc.getRemoteStreams) {
      remoteStream = pc.getRemoteStreams()[0] || null;
    }

    if (!remoteStream) {
      console.warn("No remote stream found");
      return;
    }

    mediaElement.srcObject = remoteStream;

    if (mediaElement.paused) {
      try {
        await mediaElement.play();
      } catch (error) {
        console.warn("Autoplay blocked, retrying...");
        setTimeout(async () => {
          try {
            await mediaElement.play();
          } catch (err) {
            console.error("Error playing media:", err);
          }
        }, 1000);
      }
    }
  } catch (error) {
    console.error("Error in setupRemoteMediaSimpleUserRingBackTone:", error);
  }
}
```
Reason for change:
The previous private session restricted access, making it impossible to utilize the session for ringback tone playback. By setting it to public, the session can now be used as intended. Additionally, the media setup function has been improved to ensure stability and better error handling.

Impact:
Allows the session to be accessible for ringback tone.
Ensures proper media playback and prevents unnecessary errors.
@padgad336 padgad336 marked this pull request as draft February 11, 2025 07:46
@padgad336 padgad336 marked this pull request as ready for review February 11, 2025 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant