Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup and implementation of a body wrapper in otelmux #6650

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

martinyonatann
Copy link

@martinyonatann martinyonatann commented Jan 20, 2025

setup and implementation of a body wrapper in the go.opentelemetry.io/contrib/instrumentation/github.com/gorilla/mux/otelmux package

This PR addresses feedback provided in #6648

@martinyonatann martinyonatann requested a review from a team as a code owner January 20, 2025 12:32
@github-actions github-actions bot requested a review from akats7 January 20, 2025 12:32
@martinyonatann martinyonatann force-pushed the feat/body-wrapper-for-otelmux branch from c0b62ee to 21809eb Compare January 20, 2025 12:34
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@dmathieu dmathieu added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label Jan 20, 2025
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 92.30769% with 9 lines in your changes missing coverage. Please review.

Project coverage is 68.8%. Comparing base (9a53a30) to head (0c1f634).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...trumentation/github.com/gorilla/mux/otelmux/mux.go 76.6% 5 Missing and 2 partials ⚠️
...ub.com/gorilla/mux/otelmux/request/body_wrapper.go 93.7% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #6650     +/-   ##
=======================================
+ Coverage   68.7%   68.8%   +0.1%     
=======================================
  Files        200     202      +2     
  Lines      16872   16958     +86     
=======================================
+ Hits       11601   11681     +80     
- Misses      4927    4932      +5     
- Partials     344     345      +1     
Files with missing lines Coverage Δ
...gorilla/mux/otelmux/request/resp_writer_wrapper.go 100.0% <100.0%> (ø)
...ub.com/gorilla/mux/otelmux/request/body_wrapper.go 93.7% <93.7%> (ø)
...trumentation/github.com/gorilla/mux/otelmux/mux.go 85.0% <76.6%> (-4.3%) ⬇️

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants