-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/env propagator #2110
Draft
Div95
wants to merge
7
commits into
open-telemetry:main
Choose a base branch
from
Div95:feature/env_propagator
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Feature/env propagator #2110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks @Div95. We'll have to wait till this is added to the spec. |
Ok sure. Is it ok to leave this PR open till then? |
@Div95 I moved this to drafts. You can re-open this when it is ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extended opentelemetry-python to develop a propagator that helps in inter-process propagation of trace/baggage details in a particular format (b3/w3c/any other) using environment dictionary as the carrier.
Using environment dictionary as the carrier will help to connect batch processes.
For example: The environment dictionary containing trace/baggage details can be passed to the next process
in the subprocess call, thereby propagating the trace/baggage details across processes.
The propagator has dependency on opentelemetry-api.
Relates to opentelemetry-specification issue #740
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
All the functions in the propagator have been tested using unittest library.
Following steps can be followed to run the tests:
cd opentelemetry-python/propagator/opentelemetry-propagator-env
pip install -e .[test]
For z-shell, use the command:
pip install -e ".[test]"
python3 -m unittest
Then you can uninstall the project by using the command:
pip uninstall opentelemetry-propagator-env
you could also run individual test files by using the command format:
python3 -m unittest tests.<test_file_name>.<test_file_class>
Does This PR Require a Contrib Repo Change?
Answer the following question based on these examples of changes that would require a Contrib Repo Change:
The OTel specification has changed which prompted this PR to update the method interfaces of
opentelemetry-api/
oropentelemetry-sdk/
The method interfaces of
opentelemetry-instrumentation/
have changedThe method interfaces of
test/util
have changedScripts in
scripts/
that were copied over to the Contrib repo have changedConfiguration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in
pyproject.toml
isort.cfg
.flake8
When a new
.github/CODEOWNER
is addedMajor changes to project information, such as in:
README.md
CONTRIBUTING.md
Yes. - Link to PR:
No.
Checklist: