Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Randomness requirements following W3C Trace Context level 2 #4162

Merged
merged 44 commits into from
Feb 13, 2025
Merged

Randomness requirements following W3C Trace Context level 2 #4162

merged 44 commits into from
Feb 13, 2025

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented Jul 25, 2024 •
edited
Loading

Changes

Updates Trace SDK and Propagator specifications with

  • List W3C propagator requirements (e.g., should propagate tracestate)
  • Introduce W3C Trace Context Level 2 w/ the Random flag
  • Define explicit randomness feature from OTEP 235, OTEP 261
  • Trace SDK default ID generator should include 56 bits of randomness in the correct location
  • Trace SDK for root spans: either set the random flag to confirm the above, or use an explicit randomness value.

Part of #1413.
Part of #3602.

Product of the Sampling SIG members @kentquirk @kalyanaj @oertl @PeterF778 @yuanyuanzhao3 and myself.

@jmacd jmacd changed the title Draft rules for span context in Trace Context level 2 Randomness requirements for W3C Trace Context level 2 Jul 26, 2024
@jmacd jmacd changed the title Randomness requirements for W3C Trace Context level 2 Randomness requirements following W3C Trace Context level 2 Jul 26, 2024
This was referenced Jul 29, 2024
Draft
Closed
@jmacd jmacd force-pushed the jmacd/sampling_new branch from fa9ec4c to 71750cd Compare July 29, 2024 23:22
@jmacd jmacd marked this pull request as ready for review July 29, 2024 23:24
@jmacd jmacd requested review from a team July 29, 2024 23:24
marcalff
marcalff reviewed Jul 30, 2024
View reviewed changes
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See nit comment about text formatting, for diff

specification/trace/sdk.md Outdated Show resolved Hide resolved
marcalff
marcalff approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

trask
trask reviewed Jul 30, 2024
View reviewed changes
specification/trace/sdk.md Outdated Show resolved Hide resolved
kentquirk
kentquirk reviewed Aug 1, 2024
View reviewed changes
specification/context/api-propagators.md Outdated Show resolved Hide resolved
specification/trace/tracestate-handling.md Outdated Show resolved Hide resolved
specification/trace/tracestate-handling.md Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Aug 15, 2024
@jmacd jmacd removed the Stale label Aug 15, 2024
@jmacd jmacd mentioned this pull request Nov 13, 2024
Closed
5 tasks
@github-actions GitHub Actions
Copy link

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Nov 21, 2024
@jmacd jmacd reopened this Dec 3, 2024
@github-actions GitHub Actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Dec 17, 2024
@github-actions GitHub Actions
Copy link

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Dec 25, 2024
@yuanyuanzhao3 yuanyuanzhao3 mentioned this pull request Jan 23, 2025
Closed
6 tasks
@jmacd jmacd reopened this Feb 4, 2025
@jmacd jmacd marked this pull request as ready for review February 4, 2025 00:55
@jmacd jmacd mentioned this pull request Feb 4, 2025
Open
jpkrohling
jpkrohling approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I don't see anything contentious in this PR. I'd probably prefer having a bit more context on the example shown in the PR, but that's not strictly necessary.

specification/trace/tracestate-handling.md Show resolved Hide resolved
jpkrohling
jpkrohling approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jmacd
Copy link
Contributor Author

jmacd commented Feb 13, 2025

@open-telemetry/specs-trace-approvers I believe this is ready to merge.

@reyang reyang merged commit 8155988 into open-telemetry:main Feb 13, 2025
5 of 6 checks passed
@carlosalberto carlosalberto mentioned this pull request Feb 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pellared pellared pellared left review comments

@PeterF778 PeterF778 PeterF778 approved these changes

@yuanyuanzhao3 yuanyuanzhao3 yuanyuanzhao3 approved these changes

@marcalff marcalff marcalff approved these changes

@kalyanaj kalyanaj kalyanaj approved these changes

@carlosalberto carlosalberto carlosalberto approved these changes

@lmolkova lmolkova lmolkova approved these changes

@dashpole dashpole dashpole approved these changes

@dyladan dyladan dyladan approved these changes

@kentquirk kentquirk kentquirk approved these changes

@oertl oertl oertl approved these changes

@jpkrohling jpkrohling jpkrohling approved these changes

@reyang reyang reyang approved these changes

@trask trask trask approved these changes

@tsloughter tsloughter tsloughter approved these changes

Assignees

@jack-berg jack-berg

Labels
changelog.opentelemetry.io
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.