Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed discovery of LZMA libraries #357

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed discovery of LZMA libraries #357

wants to merge 1 commit into from

Conversation

KOLANICH
Copy link

@KOLANICH KOLANICH commented Dec 2, 2019

No description provided.

Conan-Kudo
Conan-Kudo suggested changes Dec 2, 2019
View reviewed changes
CMakeLists.txt
FIND_PACKAGE (LZMA REQUIRED)
INCLUDE_DIRECTORIES (${LZMA_INCLUDE_DIR})
FIND_PACKAGE (LibLZMA REQUIRED)
INCLUDE_DIRECTORIES (${LIBLZMA_INCLUDE_DIRS})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The LZMA "package" comes from the bundled FindLZMA.cmake that is in this repository.

Copy link
Author

@KOLANICH KOLANICH Dec 2, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FindLibLZMA is a part of CMake and is better because it populates the variables with info about the version. It is proposed to drop an own wheel and use the one shipped with CMake.

@KOLANICH
Copy link
Author

@mlschroe, @ignatenkobrain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Conan-Kudo Conan-Kudo Conan-Kudo requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KOLANICH @Conan-Kudo