Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a metric for failed subscriptions #532

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

netixx
Copy link
Contributor

@netixx netixx commented Oct 22, 2024

This adds a way to monitor failed subscription response received, it makes it easier to identified missconfigured devices or subscriptions.

Maybe we should include the error in the label as well ?

@netixx netixx force-pushed the feat/failed-subscribe-metrics branch from 6805887 to 57b9d7e Compare October 22, 2024 10:05
pkg/app/metrics.go Outdated Show resolved Hide resolved
pkg/app/metrics.go Outdated Show resolved Hide resolved
pkg/app/collector.go Outdated Show resolved Hide resolved
This adds a way to monitor failed subscription response received,
it makes it easier to identified missconfigured devices or
subscriptions
@netixx netixx force-pushed the feat/failed-subscribe-metrics branch from 57b9d7e to 66c77f2 Compare October 28, 2024 08:07
@karimra
Copy link
Collaborator

karimra commented Nov 4, 2024

Thanks for the contribution and for making the changes!

@karimra karimra merged commit cc35c12 into openconfig:main Nov 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants