Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component upgrade state. #1242

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

ejbrever
Copy link
Contributor

@ejbrever ejbrever commented Jan 3, 2025

Related to #1241, this is a proposal to add upgrade state information for components.

Example output:

module: openconfig-platform
+--rw components
+--rw component* [name]
+--rw name -> ../config/name
+--ro state
| +--ro name? string
<......>
| +--ro upgrade
| +--ro new-version? string
| +--ro new-version-service-impacting? boolean
| +--ro status? identityref
| +--ro step? string
| +--ro step-percent-complete? oc-types:percentage
| +--ro total-percent-complete? oc-types:percentage
| +--ro start-timestamp? oc-types:timeticks64
| +--ro duration? yang:counter64
| +--ro stop-timestamp? oc-types:timeticks64
| +--ro last-known-failure? string

@robshakir @ahsaanyousaf could you please take a look?

@ejbrever ejbrever requested a review from a team as a code owner January 3, 2025 22:16
@ejbrever ejbrever requested a review from robshakir January 7, 2025 01:15
@LimeHat
Copy link

LimeHat commented Jan 13, 2025

Are there other use cases (in addition to transceiver FW upgrades)?
If not, shall we consider placement of this grouping in /components/component/transceiver (or introduce a new when condition based on the component type)?

@ejbrever
Copy link
Contributor Author

@LimeHat I was thinking this could apply well to generic OS installs in which we don't have this information elsewhere either (and our workflows are still retrieving it via CLI). If folks would prefer to scope this down, my main need is around firmware upgrades on transceivers though, so that would be okay for me.

@gprasat
Copy link

gprasat commented Jan 16, 2025

step-percent-complete vs total-percent-complete --> The number of steps involved in a component upgrade is not standard between components/vendors. Is there any advantage in having this represented as two different parameters ?

@ejbrever
Copy link
Contributor Author

The number of steps utilized by a given implementation should not matter. "step-percent-complete" just represents the percent complete of the in-progress step as defined by the "step" leaf. When a new "step" starts this just gets reset to 0, so it wouldn't matter if there were 2 or 10 steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants