Migrate formatting to use ruff
#95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattwthompson
commented
Oct 8, 2024
Comment on lines
-117
to
120
| # TODO: This toolkit code that had a hack to cover some edge behavior; not clear which tests trigger it | ||
| # TODO: This toolkit code that had a hack to cover some edge behavior | ||
| # not clear which tests trigger it | ||
| elif isinstance(node, ast.List): | ||
| return ast.literal_eval(node) |
There was a problem hiding this comment.
This can be tracked down to openforcefield/openff-toolkit@551a2d5 where I believe this was used to parse lists of numbers, which is no longer something this package does
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use
ruff. Don't change much else.Todos
Notable points that this PR has either accomplished or will accomplish.
Status