Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New File Picker API and adding auth parameter tests #50

Merged
merged 5 commits into from
Jan 27, 2025

Conversation

pellicceama
Copy link
Collaborator

@pellicceama pellicceama commented Jan 26, 2025

Important

Add new File Picker API and authentication parameter tests, update version to 0.1.12.

  • API Changes:
    • Add new File Picker API endpoint /connect/file-picker in openint.oas.json and openint.oas.types.d.ts.
    • Define request and response schemas for the File Picker API.
  • Authentication:
    • Modify authLink function in authLink.ts to handle ClientAuthOptions more flexibly.
    • Add tests for various authentication scenarios in index.spec.ts.
  • Version Update:
    • Update version in package.json to 0.1.12.
  • Miscellaneous:
    • Update README.md to correct command sequence.

This description was created by Ellipsis for 01043d5. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 075b03c in 1 minute and 6 seconds

More details
  • Looked at 928 lines of code in 7 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. sdks/sdk-openint/src/index.ts:60
  • Draft comment:
    The delete operation on opts?.auth?.openInt is unnecessary if opts.auth.openInt is undefined. Consider simplifying this logic.
  • Reason this comment was not posted:
    Confidence changes required: 20%
    The delete operation on opts?.auth?.openInt is conditional, but the delete operation itself is not necessary if opts.auth.openInt is undefined. This can be simplified.
2. sdks/sdk-openint/src/index.spec.ts:367
  • Draft comment:
    There are commented-out tests marked with TODO. Consider addressing these tests to ensure they are either fixed or removed if not needed.
  • Reason this comment was not posted:
    Confidence changes required: 30%
    The test file contains commented-out tests that are marked with a TODO. These should be addressed or removed to maintain code quality.

Workflow ID: wflow_G0uD9Muzcc77jlHH


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 01043d5 in 15 seconds

More details
  • Looked at 12 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. sdks/sdk-openint/package.json:3
  • Draft comment:
    Ensure that the version bump to 0.1.12 is consistent with semantic versioning practices, given the changes in the codebase. If the changes are minor or patch-level, this is appropriate.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The version bump in package.json is appropriate for a minor change or addition, such as adding a new API or tests. However, without further context on the actual changes made in the codebase, it's difficult to assess if this is the only change needed.

Workflow ID: wflow_L3bGQZanPzS3lhmC


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@pellicceama pellicceama merged commit e98ac85 into main Jan 27, 2025
1 check passed
@pellicceama pellicceama deleted the file-picker-api branch January 27, 2025 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant