Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to operator-sdk v1.39.1 #115

Open
wants to merge 48 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 39 commits
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
aefe9c5
Update to operator-sdk v1.39.1
rajchiluveru Feb 18, 2025
6193914
Update cnf-app-mac-operator makefile
rajchiluveru Feb 18, 2025
aacb754
Update cnf-app-mac-operator olm.config.yaml
rajchiluveru Feb 18, 2025
9e7564d
Update cnf-app-mac-operator basic.config.yaml
rajchiluveru Feb 18, 2025
0a98ea2
Update cnf-app-mac-operator .gitignore
rajchiluveru Feb 19, 2025
60646d7
Update cnf-app-mac-operator Dockerfile
rajchiluveru Feb 19, 2025
e1ea524
Update cnf-app-mac-operator Makefile
rajchiluveru Feb 19, 2025
f66a109
Update cnfappmac_types.go
rajchiluveru Feb 19, 2025
c93f209
Update cnfappmac_webhook.go
rajchiluveru Feb 19, 2025
e991b1c
Update cnfappmac_webhook_test.go
rajchiluveru Feb 19, 2025
94c6ed2
Update groupversion_info.go
rajchiluveru Feb 19, 2025
cc54009
Update webhook_suite_test.go
rajchiluveru Feb 19, 2025
23ad1e8
Update zz_generated.deepcopy.go
rajchiluveru Feb 19, 2025
bb5ccce
Update main.go
rajchiluveru Feb 19, 2025
2f9f780
Update examplecnf.openshift.io_cnfappmacs.yaml
rajchiluveru Feb 19, 2025
3bf714b
Update go.mod
rajchiluveru Feb 19, 2025
799d70d
Update go.sum
rajchiluveru Feb 19, 2025
bb41cbe
Update boilerplate.go.txt
rajchiluveru Feb 19, 2025
dfb30d1
Update cnfappmac_controller.go
rajchiluveru Feb 19, 2025
96c85ee
Update cnfappmac_controller_test.go
rajchiluveru Feb 19, 2025
8937710
Update suite_test.go
rajchiluveru Feb 19, 2025
44e2f96
Update e2e_suite_test.go
rajchiluveru Feb 19, 2025
984563a
Update e2e_test.go
rajchiluveru Feb 19, 2025
0d6e0fa
Update utils.go
rajchiluveru Feb 19, 2025
9565e0b
Update testpmd-operator Dockerfile
rajchiluveru Feb 19, 2025
8909aba
Update manager.yaml
rajchiluveru Feb 19, 2025
1f73d3a
Update testpmd-operator basic.config.yaml
rajchiluveru Feb 19, 2025
b162957
Update testpmd-operator olm.config.yaml
rajchiluveru Feb 19, 2025
5fa3e0b
Update trex-operator Dockerfile
rajchiluveru Feb 19, 2025
878c095
Update trex-operator Makefile
rajchiluveru Feb 19, 2025
5b63d11
Delete cnf-app-mac-operator/.gitignore
rajchiluveru Feb 20, 2025
1d00547
Delete cnf-app-mac-operator/Dockerfile
rajchiluveru Feb 20, 2025
afd0156
Updated correct version in Makefile
rajchiluveru Feb 20, 2025
f56a5f3
removed docker entry in Makefile
rajchiluveru Feb 20, 2025
f865bc4
removed rbac Makefile
rajchiluveru Feb 20, 2025
6d39eba
Update d version var in Makefile
rajchiluveru Feb 20, 2025
effa041
Update trex-operator CHANGELOG.md
rajchiluveru Feb 20, 2025
d80993e
Updated trex-operator versions in Dockerfile
rajchiluveru Feb 20, 2025
35d2912
Updated version Range in required-annotations.yaml
rajchiluveru Feb 20, 2025
66d2218
added deleted files
rajchiluveru Feb 20, 2025
6d2f20f
added deleted files
rajchiluveru Feb 20, 2025
6222d95
updated Makefile
rajchiluveru Feb 20, 2025
f647216
updated go.mod file
rajchiluveru Feb 20, 2025
650c9a7
updated go.sum file
rajchiluveru Feb 20, 2025
bf450f8
updated go.sum file
rajchiluveru Feb 20, 2025
390d632
updated go.sum file
rajchiluveru Feb 20, 2025
ccfe4e8
updated Dockerfile file
rajchiluveru Feb 20, 2025
439f1dc
updated Dockerfile file
rajchiluveru Feb 20, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ SHELL := /bin/bash

DIRS := testpmd-container-app trex-container-app cnf-app-mac-operator testpmd-operator trex-operator nfv-example-cnf-index

OPERATOR_SDK_VER:= 1.38.0
OPERATOR_SDK_VER:= 1.39.1

# Print the possible targets and a short description
.PHONY: targets
Expand Down
31 changes: 0 additions & 31 deletions cnf-app-mac-operator/.gitignore
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this file deleted?

This file was deleted.

44 changes: 0 additions & 44 deletions cnf-app-mac-operator/Dockerfile
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this file deleted?

This file was deleted.

18 changes: 9 additions & 9 deletions cnf-app-mac-operator/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@
# To re-generate a bundle for another specific version without changing the standard setup, you can:
# - use the VERSION as arg of the bundle target (e.g make bundle VERSION=0.0.2)
# - use environment variables to overwrite this value (e.g export VERSION=0.0.2)
VERSION := 0.2.22
VERSION := 0.2.23

# Set the Operator SDK version to use. By default, what is installed on the system is used.
# This is useful for CI or a project to utilize a specific version of the operator-sdk toolkit.
OPERATOR_SDK_VER ?= 1.38.0
OPERATOR_SDK_VER ?= 1.39.1

# Other custom variables
SHELL := /bin/bash
Expand All @@ -20,8 +20,8 @@ DEFAULT_CHANNEL ?= alpha
CONTAINER_CLI ?= podman
CLUSTER_CLI ?= oc
OPERATOR_NAME := cnf-app-mac-operator
CONTROLLER_VER := v0.15.0
KUSTOMIZE_VER := v5.4.2
CONTROLLER_VER := v0.16.1
KUSTOMIZE_VER := v5.4.3
OPM_VER := 1.23.0
OS = $(shell uname -s | tr '[:upper:]' '[:lower:]')
ARCH = $(shell uname -m | sed 's/x86_64/amd64/')
Expand Down Expand Up @@ -70,7 +70,7 @@ IMG ?= $(IMAGE_TAG_BASE):v$(TAG)
REL_IMG ?= $(IMAGE_TAG_BASE):v$(VERSION)

# ENVTEST_K8S_VERSION refers to the version of kubebuilder assets to be downloaded by envtest binary.
ENVTEST_K8S_VERSION = 1.30.0
ENVTEST_K8S_VERSION = 1.31.0

# Get the currently used golang install path (in GOPATH/bin, unless GOBIN is set)
ifeq (,$(shell go env GOBIN))
Expand Down Expand Up @@ -166,11 +166,11 @@ build: manifests generate fmt vet ## Build manager binary.
run: manifests generate fmt vet ## Run a controller from your host.
go run ./cmd/main.go

# If you wish built the manager image targeting other platforms you can use the --platform flag.
# If you wish to build the manager image targeting other platforms you can use the --platform flag.
# (i.e. docker build --platform linux/arm64 ). However, you must enable docker buildKit for it.
# More info: https://docs.docker.com/develop/develop-images/build_enhancements/
.PHONY: docker-build
docker-build: test ## Build docker image with the manager.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependency with test task is required, you cannot delete it. That's why the build PR Github action is failing right now.

docker-build: ## Build docker image with the manager.
$(CONTAINER_CLI) build -t ${IMG} .

.PHONY: docker-push
Expand Down Expand Up @@ -220,7 +220,7 @@ deploy: manifests kustomize ## Deploy controller to the K8s cluster specified in
$(KUSTOMIZE) build config/default | $(CLUSTER_CLI) apply -f -

.PHONY: undeploy
undeploy: ## Undeploy controller from the K8s cluster specified in ~/.kube/config. Call with ignore-not-found=true to ignore resource not found errors during deletion.
undeploy: kustomize ## Undeploy controller from the K8s cluster specified in ~/.kube/config. Call with ignore-not-found=true to ignore resource not found errors during deletion.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't delete kustomize dependency as well, this is needed

$(KUSTOMIZE) build config/default | $(CLUSTER_CLI) delete --ignore-not-found=$(ignore-not-found) -f -

##@ Dependencies
Expand All @@ -237,7 +237,7 @@ ENVTEST ?= $(LOCALBIN)/setup-envtest
GOLANGCI_LINT = $(LOCALBIN)/golangci-lint

## Tool Versions
ENVTEST_VERSION ?= release-0.18
ENVTEST_VERSION ?= release-0.19
GOLANGCI_LINT_VERSION ?= v1.59.1

.PHONY: kustomize
Expand Down
2 changes: 1 addition & 1 deletion cnf-app-mac-operator/api/v1/cnfappmac_types.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
Copyright 2024.
Copyright 2025.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
Expand Down
2 changes: 1 addition & 1 deletion cnf-app-mac-operator/api/v1/cnfappmac_webhook.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
Copyright 2024.
Copyright 2025.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
Expand Down
2 changes: 1 addition & 1 deletion cnf-app-mac-operator/api/v1/cnfappmac_webhook_test.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
Copyright 2024.
Copyright 2025.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
Expand Down
2 changes: 1 addition & 1 deletion cnf-app-mac-operator/api/v1/groupversion_info.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
Copyright 2024.
Copyright 2025.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
Expand Down
4 changes: 2 additions & 2 deletions cnf-app-mac-operator/api/v1/webhook_suite_test.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
Copyright 2024.
Copyright 2025.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -138,8 +138,8 @@ var _ = BeforeSuite(func() {
})

var _ = AfterSuite(func() {
cancel()
By("tearing down the test environment")
cancel()
err := testEnv.Stop()
Expect(err).NotTo(HaveOccurred())
})
2 changes: 1 addition & 1 deletion cnf-app-mac-operator/api/v1/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion cnf-app-mac-operator/cmd/main.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
Copyright 2024.
Copyright 2025.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.15.0
controller-gen.kubebuilder.io/version: v0.16.1
name: cnfappmacs.examplecnf.openshift.io
spec:
group: examplecnf.openshift.io
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
entrypoint:
- scorecard-test
- basic-check-spec
image: quay.io/operator-framework/scorecard-test:v1.38.0
image: quay.io/operator-framework/scorecard-test:v1.39.1
labels:
suite: basic
test: basic-check-spec-test
10 changes: 5 additions & 5 deletions cnf-app-mac-operator/config/scorecard/patches/olm.config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
entrypoint:
- scorecard-test
- olm-bundle-validation
image: quay.io/operator-framework/scorecard-test:v1.38.0
image: quay.io/operator-framework/scorecard-test:v1.39.1
labels:
suite: olm
test: olm-bundle-validation-test
Expand All @@ -14,7 +14,7 @@
entrypoint:
- scorecard-test
- olm-crds-have-validation
image: quay.io/operator-framework/scorecard-test:v1.38.0
image: quay.io/operator-framework/scorecard-test:v1.39.1
labels:
suite: olm
test: olm-crds-have-validation-test
Expand All @@ -24,7 +24,7 @@
entrypoint:
- scorecard-test
- olm-crds-have-resources
image: quay.io/operator-framework/scorecard-test:v1.38.0
image: quay.io/operator-framework/scorecard-test:v1.39.1
labels:
suite: olm
test: olm-crds-have-resources-test
Expand All @@ -34,7 +34,7 @@
entrypoint:
- scorecard-test
- olm-spec-descriptors
image: quay.io/operator-framework/scorecard-test:v1.38.0
image: quay.io/operator-framework/scorecard-test:v1.39.1
labels:
suite: olm
test: olm-spec-descriptors-test
Expand All @@ -44,7 +44,7 @@
entrypoint:
- scorecard-test
- olm-status-descriptors
image: quay.io/operator-framework/scorecard-test:v1.38.0
image: quay.io/operator-framework/scorecard-test:v1.39.1
labels:
suite: olm
test: olm-status-descriptors-test
Loading
Loading